Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: top bar not centered when on-premises backend is visible [WPB-9383] 🍒 #3029

Merged
merged 3 commits into from
May 24, 2024
Merged

fix: top bar not centered when on-premises backend is visible [WPB-9383] 🍒 #3029

merged 3 commits into from
May 24, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 23, 2024 •
edited
Loading

BugWPB-9383 [Android] Login screen misaligned

This PR was automatically cherry-picked based on the following PR:

Original PR description:

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Top bar title and subtitle are not centered when there's an on-premises backend info visible.

Causes (Optional)

For CenterAlignedTopAppBar, Android calculates the position of title's composable according to its width, which means that this composable shouldn't have fillMaxWidth or fillMaxSize set, otherwise it will take the entire space and won't center it properly because it won't be possible.

Solutions

Remove fillMaxWidth from ServerTitle - it's used on the top bar and this modifier is absolutely not needed there, it will work the same without it.

Testing

How to Test

Open login screen and deep link into a custom backend.

Attachments (Optional)

Before After
Screenshot_20240522_161249 Screenshot_20240522_164909

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/XS labels May 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.30%. Comparing base (d26b742) to head (8f0e662).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3029      +/-   ##
===========================================
+ Coverage    44.25%   44.30%   +0.04%     
===========================================
  Files          448      448              
  Lines        14519    14517       -2     
  Branches      2495     2493       -2     
===========================================
+ Hits          6426     6432       +6     
+ Misses        7391     7382       -9     
- Partials       702      703       +1

see 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25f8a2f...8f0e662. Read the comment docs.

@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented May 23, 2024 •
edited
Loading

Test Results

930 tests   930 ✅  8m 52s ⏱️
124 suites    0 💤
124 files      0 ❌

Results for commit 8f0e662.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor Author

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk saleniuk requested review from a team, typfel, borichellow, MohamadJaara, Garzas and saleniuk and removed request for a team May 23, 2024 09:14
@AndroidBob
Copy link
Collaborator

Build 4933 succeeded.

The build produced the following APK's:

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor Author

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4945 succeeded.

The build produced the following APK's:

@saleniuk saleniuk added this pull request to the merge queue May 24, 2024
Merged via the queue into develop with commit ac4c4a2 May 24, 2024
14 checks passed
@saleniuk saleniuk deleted the fix/center-aligned-top-bar-cherry-pick branch May 24, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleniuk saleniuk saleniuk approved these changes

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

Assignees

@saleniuk saleniuk

Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codecov-commenter @AndroidBob @MohamadJaara @saleniuk